Update matrix file each time a matrix changes while polling #533
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## master #533 +/- ##
========================================
Coverage 78.6% 78.6%
Complexity 560 560
========================================
Files 77 77
Lines 2141 2141
Branches 289 289
========================================
Hits 1683 1683
Misses 289 289
Partials 169 169 |
|
Thanks. The change looks good. There's not a great way to test this until FTL open sources their mock server. The current mock server we have doesn't support polling. We could update it to support polling but I'm hoping to use the official FTL mock server in the future. |
if (MatrixState.completed(refreshedMatrix.state)) {
break
}that means we exit after a matrix reaches a final state. The write/update logic happens after that, and thus misses the final update to the the matrix_ids.json. I fixed this in: #534 I found the bug by using flank on our iOS Student app :) |
|
🤦♂️ nice find, sorry about that! |
|
no problem, it's a gap in our testing coverage 😄 I will hopefully be improving that in the future. |
When a Flank execution hangs (due to a broken test or an FTL outage) and is killed by a timeout (on Jenkins, Bitrise, etc.), it's nice to be able to find the FTL console link associated with each shard in order to debug the issue. These are normally printed to stdout at the end of a test run, but they might not be logged if the run is killed before completing.
Fortunately, Flank also persists a
matrix_ids.jsonfile to disk that contains the FTL link. This PR increases the frequency with which that file is updated, so that FTL links will make it into the file as soon as they're available.I was hoping to add a test here but I was having trouble writing one that really covered this logic -- let me know if you have an idea for how to do that 😄